Some elements of good practices implemented - #341
Draft
e-perl-NOAA wants to merge 1 commit into
Draft
Conversation
Contributor
New version checklist
|
Contributor
Code Metrics Report
Code coverage of files in pull request scope (66.4%)
Reported by octocov |
Collaborator
There was a problem hiding this comment.
Note: the filter_data should not be showing errors and have missing argument documentation because it is sharing the same documentation from spawning_biomass through inheritParams. I am curious why the check said this was missing
Collaborator
There was a problem hiding this comment.
need to check if this is moved to utils. If so, can be removed, if not then this needs to stay. It is referenced in a couple lines below
Schiano-NOAA
requested changes
Aug 20, 2026
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
I will make the changes neccessary to merge this. Thanks @e-perl-NOAA for getting this started. This is a big help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not finished - see notes in issue #117